Skip to content

Conversation

@almarklein
Copy link
Member

@almarklein almarklein commented May 9, 2023

Fix some leftover references to up. See #482.

  • Fixed some docstrings that still mentioned minus/reverse from when reference_up was called gravity.
  • Fixed that ob.world.reference_up was initially a tuple (its an array everywhere else).
  • Fixed that setting ob.world.reference_up was undone when the local transform changed (the change in world.reference_up was not propagated to the local transform.
  • Added a test to make sure the above stays working, based using camera.show_pos.
  • Prefixed two callback functions with an underscore.
  • Update all (I think) cases that still used ob.up instead of ob.world.reference_up.

@almarklein almarklein marked this pull request as ready for review May 10, 2023 20:05
@almarklein almarklein requested a review from Korijn as a code owner May 10, 2023 20:05
@Korijn Korijn merged commit f3816b2 into main May 11, 2023
@Korijn Korijn deleted the up branch May 11, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants