Skip to content

Making widgets more responsive to screen resizing and other UI improvements#927

Open
CORRUPTOR2037 wants to merge 19 commits into
pyglet:masterfrom
CORRUPTOR2037:master
Open

Making widgets more responsive to screen resizing and other UI improvements#927
CORRUPTOR2037 wants to merge 19 commits into
pyglet:masterfrom
CORRUPTOR2037:master

Conversation

@CORRUPTOR2037

Copy link
Copy Markdown

No description provided.

@pushfoo pushfoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of this PR's changes are very good. To help merge them faster, it would help to split parts off into separate PRs:

  • Make a backup branch just in case:

    git branch backup_layout_branch
  • Split the resize helpers into their own PR: #930

    1. Split the changes into their own branch
      git branch add_widget_resize_helpers
      git checkout add_widget_resize_helpers
      git reset --hard 4744cc06
      git cherry-pick ba4a5d6a
      git push --set-upstream origin add_widget_resize_helpers
    2. Make the PR for widget resizing: https://github.com/CORRUPTOR2037/pyglet/pull/new/add_widget_resize_helpers
  • Split the hotkey support for TextEntry into its own branch based off the previous one: #931

    1. Split the changes into a branch based off add_widget_resize_helpers
      git branch add_textentry_hotkeys
      git checkout add_textentry_hotkeys
      git cherry-pick 94c3138
      git push --set-upstream origin add_textentry_hotkeys
    2. Make the PR for widget resizing: https://github.com/CORRUPTOR2037/pyglet/pull/new/add_textentry_hotkeys

CORRUPTOR2037 added 2 commits August 27, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants