Making widgets more responsive to screen resizing and other UI improvements#927
Open
CORRUPTOR2037 wants to merge 19 commits into
Open
Making widgets more responsive to screen resizing and other UI improvements#927CORRUPTOR2037 wants to merge 19 commits into
CORRUPTOR2037 wants to merge 19 commits into
Conversation
added 6 commits
August 22, 2023 19:45
… movement outside of frame
(only select all supported because there is no clipboard support in pyglet)
pushfoo
suggested changes
Aug 26, 2023
Contributor
There was a problem hiding this comment.
Some of this PR's changes are very good. To help merge them faster, it would help to split parts off into separate PRs:
-
Make a backup branch just in case:
git branch backup_layout_branch -
Split the resize helpers into their own PR: #930
- Split the changes into their own branch
git branch add_widget_resize_helpers git checkout add_widget_resize_helpers git reset --hard 4744cc06 git cherry-pick ba4a5d6a git push --set-upstream origin add_widget_resize_helpers
- Make the PR for widget resizing: https://github.com/CORRUPTOR2037/pyglet/pull/new/add_widget_resize_helpers
- Split the changes into their own branch
-
Split the hotkey support for
TextEntryinto its own branch based off the previous one: #931- Split the changes into a branch based off
add_widget_resize_helpersgit branch add_textentry_hotkeys git checkout add_textentry_hotkeys git cherry-pick 94c3138 git push --set-upstream origin add_textentry_hotkeys
- Make the PR for widget resizing: https://github.com/CORRUPTOR2037/pyglet/pull/new/add_textentry_hotkeys
- Split the changes into a branch based off
added 2 commits
August 27, 2023 01:09
…nto separated class, added nine patch sprite mesh generator
added 11 commits
September 15, 2023 09:16
… values, vertical orientation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.