Allow newer python versions to test on MacOS mimicking Ubuntu workflows #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong term solution
Collaborator
Author
|
This PR does not yet address the downstream issue in: pydata/xarray/#4348. |
jgallagher59701
approved these changes
Mar 12, 2024
Member
jgallagher59701
left a comment
There was a problem hiding this comment.
Look at my two comments and let me know. Aside from that, this looks ready to merge.
Lets also talk about a long term solution. My Python knowledge is limited and I wonder if moving from WSGI to Flask might be a good move overall since that might reduce the amount of lower level configuration we have to do.
Collaborator
Author
Yeah. That makes sense to me. That should take place on a separate issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
pydapto work with newer python version in both macOS and Windows env.python=3.10There was an earlier effort to update the python versions for testing workflow on #283. This PR essentially allows that to happen. However, this PR does not address the issue raised in #292 with
multiprocessing.Process and netcdf. But it allows for updated testing workflow by skipping tests that may fail on MacOS (there is no issue on Ubuntu / linux). A separate PR should address #292.Suggestions are welcome. This can also be a draft PR, but I do think that there is merit in updating the testing (python) environment, while also identifying the issues with MacOS and Windows