-
Notifications
You must be signed in to change notification settings - Fork 89
Fixes #207: Pydap can now use PasterApp and serve data #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jgallagher59701
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my question about the WSGI interface (?) class comment.
But, this looks good. And I think it can be merged.
Do you think we can read data from DMR++ documents using this framework?
|
|
||
|
|
||
| class PyDapApplication(WSGIApplication): | ||
| """An application interface for configuring and loading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the interface class for loading a WSGI application into the WSGI framework?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. PyDapApplication inherits from WSGIApplication in a way that we can customize it. I did some bare minimum for now.
That's a good question. probably... Definitely an avenue worth exploring. I not super familiar with WSGI applications, nor Gunicorn, but I know that Gunicorn is lightweight, customizable, and that can handle concurrent requests efficiently. Definitely a good starting point. |
The following Pull Request is a continuation of PR #286 started by @raphaeljolivet (Thanks for the contribution!)
on a local environment.
pydapas a server app.With these changes, and gunicorn installed (any version), the following updated line in the README file works again: