Skip to content

🗒️❓ Optional evaluation for pipeline#919

Open
mberr wants to merge 22 commits into
masterfrom
pipeline-optional-eval
Open

🗒️❓ Optional evaluation for pipeline#919
mberr wants to merge 22 commits into
masterfrom
pipeline-optional-eval

Conversation

@mberr

@mberr mberr commented May 10, 2022

Copy link
Copy Markdown
Member

This PR works towards making the evaluation in the pipeline function optional.

Comment thread src/pykeen/pipeline/api.py Outdated
@cthoyt

cthoyt commented May 10, 2022

Copy link
Copy Markdown
Member

the pipeline has become a proper frankenstein monster at this point

@mberr

mberr commented May 10, 2022

Copy link
Copy Markdown
Member Author

the pipeline has become a proper frankenstein monster at this point

It might be worth to try to separate the resolution logic from running training / evaluation.

@mberr mberr changed the title Optional evaluation for pipeline 🗒️❓ Optional evaluation for pipeline Sep 23, 2023
@mberr mberr marked this pull request as ready for review September 23, 2023 22:24
@cthoyt

cthoyt commented Sep 24, 2023

Copy link
Copy Markdown
Member

I am still skeptical of making evaluation optional. I like that the pipeline does exactly one thing, and if you want to roll your own with different functionality, there is a tutorial at https://pykeen.readthedocs.io/en/stable/tutorial/first_steps.html#beyond-the-pipeline that makes it pretty simple

It doesn't help that this PR also has big refactoring that isn't obviously relevant to making evaluation optional

@mberr

mberr commented Sep 24, 2023

Copy link
Copy Markdown
Member Author

It doesn't help that this PR also has big refactoring that isn't obviously relevant to making evaluation optional

The handle_dataset part needed to be changed to allow validation/testing to be optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants