Skip to content

Session::run{,_async}() now takes &mut self #402

Description

@ia0

In ort-1.16.3 and ort-2.0.0-rc.9, Session::run() (and Session::run_async() for v2) take &self which is very convenient when sharing a session across multiple threads.

Since ort-2.0.0-rc.10, those functions now take &mut self which is a noticeable change because users have to redesign their usage of ort (e.g. creating one Session per execution thread instead of sharing a unique one).

This raises 2 questions:

  • What is the rationale for bd2aff7? (the commit does not seem to be part of a PR and the commit has no description)
  • Why is this not documented in the migration guide?

To be clear, I don't mind the change, I'm just surprised it went silently (unless I missed some documentation).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions