Skip to content

New feature IMDb#191

Merged
paulosgf merged 11 commits into
pyhoneybot:masterfrom
ZoeyKats:master
Mar 9, 2023
Merged

New feature IMDb#191
paulosgf merged 11 commits into
pyhoneybot:masterfrom
ZoeyKats:master

Conversation

@ZoeyKats

@ZoeyKats ZoeyKats commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

I have written the code for imdb feature, i hope you like it

  • I have read, understood and followed our Contributing Guide
  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I added my country flag to the README.md

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct

  • I agree to follow this project's Code of Conduct

@CLAassistant

CLAassistant commented Feb 15, 2023

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ZoeyKats
✅ Abdur-rahmaanJ
❌ pre-commit-ci-lite[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@Abdur-rahmaanJ

Copy link
Copy Markdown
Member

Hey @ZoeyKats Can you add it to the README? Thanks!

@ZoeyKats

Copy link
Copy Markdown
Contributor Author

Sure i just did it!

@MrTanoshii

Copy link
Copy Markdown
Member

Sure i just did it!

Hey there, thanks for the contribution!

I see you opened another PR for the README.md changes
Can you please merge the two into this one?
You can do so by closing #192 and merges your changes to the same main branch ZoeyKats:master.

There's also a few issues with regards to formatting/style

Can you please do the following:

@MrTanoshii MrTanoshii self-requested a review February 16, 2023 10:38
@MrTanoshii MrTanoshii added enhancement New feature or request plugin Related to honeybot plugins labels Feb 16, 2023
@MrTanoshii MrTanoshii mentioned this pull request Feb 16, 2023
5 tasks
@ZoeyKats

Copy link
Copy Markdown
Contributor Author

I finished what you asked me to do, I hope everything is ok. Please tell me if there is something else I need to do

@ZoeyKats

Copy link
Copy Markdown
Contributor Author

I found out I messed up a little bit when I formatted the code. I just committed the correct one. Sorry for any trouble

@paulosgf

paulosgf commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

@Abdur-rahmaanJ and @MrTanoshii , there are something missing here? Or we already can merge it?

@Abdur-rahmaanJ

Copy link
Copy Markdown
Member

@paulosgf we can merge!

@paulosgf paulosgf merged commit 2a9e813 into pyhoneybot:master Mar 9, 2023
@paulosgf

Copy link
Copy Markdown
Collaborator

@ZoeyKats, I'm updating de documentation and then I found a bug complaining that the imdb module is missing. I'm trying to install it, but PyPI has no module named imdb. How I can import it?
Here's the error logs:

WARNING: autodoc: failed to import module 'main' from module 'plugins.downloaded.movies_imdb'; the following exception was raised: No module named 'imdb'
$ pip install imdb ERROR: Could not find a version that satisfies the requirement imdb (from versions: none) ERROR: No matching distribution found for imdb

@ZoeyKats

Copy link
Copy Markdown
Contributor Author

@paulosgf you can try pip install cinemagoer , sorry for not mentioning it earlier i had totally forgotten about this issue. I think the package IMDbPY was renamed to cinemagoer that's the reason it changed.

@paulosgf

Copy link
Copy Markdown
Collaborator

Can you update your plug-in with this module? Don't forget requirements.txt
Thanks!

@paulosgf

Copy link
Copy Markdown
Collaborator

Can you update your plug-in with this module? Don't forget requirements.txt Thanks!

@ZoeyKats , did you see this message?

@paulosgf paulosgf mentioned this pull request Mar 18, 2023
1 task
@ZoeyKats

Copy link
Copy Markdown
Contributor Author

@paulosgf hey sorry i just saw this, i'll make sure to change it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugin Related to honeybot plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants