Skip to content

Pull Requests

Thomas Perret edited this page Aug 17, 2015 · 3 revisions

Warning : this is a draft version of the document. Do not consider the following accurate.

Make a pull request

  1. Before making a pull request with your feature branch, ensure to rebase this branch on the latest commit on master branch.
  2. Make your pull request and indicate on the message which ticket(s) your PR is closing or resolving if it qualifies
  3. Assign someone else to the PR (the most competent for reviewing this specific PR)

Working on a PR

If someone assigned you to a PR:

First, check that you are qualified to review thit PR, if not, assign someone else (not the person who made the PR)

  1. Check that the PR can be fast-forward merged
  2. Check that travis-ci.com is reporting the PR as good
  3. Check that coveralls.io does not report a lower coverage
  4. Checkout the PR locally and test the code (new functionalities, possible regressions,…)
  5. If everything is OK, merge it

Clone this wiki locally