-
Notifications
You must be signed in to change notification settings - Fork 21
Pull Requests
Thomas Perret edited this page Aug 17, 2015
·
3 revisions
Warning : this is a draft version of the document. Do not consider the following accurate.
- Before making a pull request with your feature branch, ensure to rebase this branch on the latest commit on master branch.
- Make your pull request and indicate on the message which ticket(s) your PR is closing or resolving if it qualifies
- Assign someone else to the PR (the most competent for reviewing this specific PR)
If someone assigned you to a PR:
First, check that you are qualified to review thit PR, if not, assign someone else (not the person who made the PR)
- Check that the PR can be fast-forward merged
- Check that travis-ci.com is reporting the PR as good
- Check that coveralls.io does not report a lower coverage
- Checkout the PR locally and test the code (new functionalities, possible regressions,…)
- If everything is OK, merge it