-
Notifications
You must be signed in to change notification settings - Fork 33
Making import relative (conda bug) #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 04dba035bcb3170b7bfed3e2ce0895e9a6a36ea5-PR-99
💛 - Coveralls |
pariterre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@romainmartinez even though the line 8 reads from .io (I changed it locally) |
|
Okay, just found the problem, with the command to install, only the main folder is copied, but not the subfolder, so ".io" is actually not there |
It does not work with python setup install, but it does with pip install .
|
@romainmartinez |
|
Found a proper solution 😃
it works locally using |
| import xarray as xr | ||
|
|
||
| from .angles import Angles | ||
| from pyomeca import Angles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this may cause problem if ones has a pyomeca installed, but also has imported the folder (as a symbolic link for instance)?
| from scipy.optimize import least_squares | ||
|
|
||
| from ..angles import Angles | ||
| from pyomeca import Angles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idem as next comment (if the answer is no, then you can merge! You will have to do another release so I can update the conda PR)
No description provided.