Skip to content

adapted check_array() keyword - sklearn version#400

Merged
jGaboardi merged 1 commit into
pysal:mainfrom
jGaboardi:adapt_for_new_sklearn
Dec 14, 2025
Merged

adapted check_array() keyword - sklearn version#400
jGaboardi merged 1 commit into
pysal:mainfrom
jGaboardi:adapt_for_new_sklearn

Conversation

@jGaboardi

Copy link
Copy Markdown
Member

This PR provides an adapted keyword for the sklearn.utils.check_array() call that was causing CI to fail.

@jGaboardi

Copy link
Copy Markdown
Member Author

But now we have an unrelated failure in ci/313-min.yaml that was not present yesterday.

pyogrio.errors.FeatureError: At line 1, character 12012: Unterminated object

@jGaboardi

Copy link
Copy Markdown
Member Author

@martinfleis – any idea about this pyogrio.errors.FeatureError?

@codecov

codecov Bot commented Dec 14, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.7%. Comparing base (a4f4ef6) to head (66613f6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #400   +/-   ##
=====================================
  Coverage   82.7%   82.7%           
=====================================
  Files         27      27           
  Lines       3825    3829    +4     
=====================================
+ Hits        3162    3166    +4     
  Misses       663     663           
Files with missing lines Coverage Δ
esda/geary_local_mv.py 98.9% <100.0%> (+<0.1%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi

Copy link
Copy Markdown
Member Author

@martinfleis – now I see passing CI. Thought I was going crazy, then I realized you retriggered. So just a fluke.

@martinfleis martinfleis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was probably just a corrupted download of the file.

@jGaboardi jGaboardi merged commit 56bb603 into pysal:main Dec 14, 2025
29 of 30 checks passed
@jGaboardi jGaboardi deleted the adapt_for_new_sklearn branch December 14, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants