Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.2%. Comparing base (3fa6225) to head (2885d8f).
⚠️ Report is 9 commits behind head on main.

@@           Coverage Diff           @@
##            main    #246     +/-   ##
=======================================
- Coverage   88.2%   88.2%   -0.1%     
=======================================
  Files         10      10             
  Lines       1591    1584      -7     
=======================================
- Hits        1404    1397      -7     
  Misses       187     187             

@weikang9009 awesome!

Should we also tie in these other splot removals in this PR?

• environment.yml
• pyproject.toml
• and the ci/*.yml files

Yes! I thought those were removed - sorry for misreading and closing that issue.

I've just pushed another commit to this PR to remove splot from those files.

One of the CI testing failed because of https://github.com/pysal/giddy/blob/main/giddy/plotting.py#L591 I think esda has this plotting functionality? Since esda is a dependency, we can replace it with the esda function.

One of the CI testing failed because of https://github.com/pysal/giddy/blob/main/giddy/plotting.py#L591 I think esda has this plotting functionality? Since esda is a dependency, we can replace it with the esda function.

esda>=2.7 has the functionality, so if simply bump the minimum esda version to 2.7 we can clean up that logic block nicely.

Thoughts?

I'll see about making those changes in your branch here and push back up.