[DO NOT MERGE] Change to the new sparse arrays and see what breaks#529
Closed
ljwolf wants to merge 1 commit into
Closed
[DO NOT MERGE] Change to the new sparse arrays and see what breaks#529ljwolf wants to merge 1 commit into
ljwolf wants to merge 1 commit into
Conversation
Member
|
@ljwolf can we close this given the Graph is using sparse array and there's likely no apetite to make changes in weights? |
Member
Author
|
yep, fine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scipy is moving to a new sparse array type, and eventually deprecating the sparse matrix type. We need to check what breaks when we use it. Right now, I see a few failures locally, so I want to get this online for others to see.