Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.4%. Comparing base (f134a92) to head (e47859e).
⚠️ Report is 13 commits behind head on main.

@@           Coverage Diff           @@
##            main    #806     +/-   ##
=======================================
- Coverage   85.4%   85.4%   -0.0%     
=======================================
  Files        150     150             
  Lines      15951   15954      +3     
=======================================
+ Hits       13618   13620      +2     
- Misses      2333    2334      +1     

I gave up as I got no clue how to make Pulp behave. the only red is momepy now.

@martinfleis - Did we want to try more fixing the PuLP install or give up for now?

@jGaboardi if you have any idea how to go about it, I am not against.

@jGaboardi if you have any idea how to go about it, I am not against.

I don't have time these next few days to look in it. Do you have any ideas @gegen07 ?

I'll go ahead and approve this now if we want to circle back and look at the PuLP stuff later.

@martinfleis @jGaboardi
I think I gotcha, if the pulp is installed using conda-forge we will not have permission to use PULP_CBC_CMD. One possible workaround is to change the feedstock recipe. Installing pulp from conda-forge is causing an error here at reverse dependency testing because neither glpk nor coincbc are described as necessary.

Note that spopt environment file requires glpk. We can choose just one solver as default glpk or cbc, then do the changes across the environment. I vote for maintaining glpk as in environment.yml, then propagate the changes to the tests (change PULP_CBC_CMD to GLPK_CMD).

One possible workaround is to change the feedstock recipe. Installing pulp from conda-forge is causing an error here at reverse dependency testing because neither glpk nor coincbc are described as necessary.

That sounds like something the recipe should solve. If installing pulp is not enough to make pulp-based code running, we need to include the additional dependencies.

@gegen07 neither adding coincbc or glpk solves the issue.

Forcing pulp from PyPI solves it, though it is a bit ugly.

@gegen07 Any idea why conda-forge installation does not work? Seems like a bug in pulp recipe, no?

Yep! I did a fresh spopt installation, adding coin-or-cbc package in environment.yml, and it's still not working. I think we are using a solver (PULP_COIN_CMD) that is only installed when using PyPI version.

If we change the solver to COIN_CMD it worked and the tests did not break. I'll do the changes later this week on spopt to use only conda dependencies. 👍🏻

@martinfleis great work on this 🙇

@gegen07 very much appreciate your help here 🙇

looks like it is a conda-forge thing conda-forge/pulp-feedstock#22