Skip to content

ENH: add information about components and isolates to Graph.__repr__#815

Merged
martinfleis merged 4 commits into
pysal:mainfrom
martinfleis:connectivity-repr
Dec 24, 2025
Merged

ENH: add information about components and isolates to Graph.__repr__#815
martinfleis merged 4 commits into
pysal:mainfrom
martinfleis:connectivity-repr

Conversation

@martinfleis

@martinfleis martinfleis commented Dec 11, 2025

Copy link
Copy Markdown
Member

Closes #807

@codecov

codecov Bot commented Dec 11, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.4%. Comparing base (e47859e) to head (409b938).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #815   +/-   ##
=====================================
  Coverage   85.4%   85.4%           
=====================================
  Files        150     150           
  Lines      15954   15958    +4     
=====================================
+ Hits       13620   13625    +5     
+ Misses      2334    2333    -1
Files with missing lines Coverage Δ
libpysal/graph/base.py 96.5% <100.0%> (+<0.1%) ⬆️
libpysal/graph/tests/test_base.py 100.0% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi

jGaboardi commented Dec 11, 2025

Copy link
Copy Markdown
Member

Is this failure due to the new repr?

FAILED libpysal/graph/tests/test_base.py::TestBase::test_sparse_roundtrip - AssertionError: assert <Graph of 9 n...d', 'e', ...]> == <Graph of 9 n...d', 'e', ...]>
  
  Full diff:
    <Graph of 9 nodes and 9 nonzero edges (1 component, 0 isolates) indexed by
     ['a', 'b', 'c', 'd', 'e', ...]>

@martinfleis

martinfleis commented Dec 11, 2025

Copy link
Copy Markdown
Member Author

No - https://github.com/pysal/libpysal/actions/runs/20118036076/job/57732032807

@martinfleis martinfleis merged commit 05e0c31 into pysal:main Dec 24, 2025
12 checks passed
@martinfleis martinfleis deleted the connectivity-repr branch December 24, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jGaboardi jGaboardi jGaboardi approved these changes

@sjsrey sjsrey Awaiting requested review from sjsrey

Assignees

No one assigned

Labels

enhancement graph

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Connectivity warnings on Graph

2 participants

@martinfleis @jGaboardi