Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.4%. Comparing base (bfa42b7) to head (e3a6c91).
⚠️ Report is 7 commits behind head on main.

@@          Coverage Diff          @@
##            main    #824   +/-   ##
=====================================
  Coverage   85.4%   85.4%           
=====================================
  Files        151     151           
  Lines      16015   16025   +10     
=====================================
+ Hits       13679   13689   +10     
  Misses      2336    2336           

The issue in CI is linked to numpy 1.26, which is already out of SPEC 0 support window. Shall we just bump the pin?

The issue in CI is linked to numpy 1.26, which is already out of SPEC 0 support window. Shall we just bump the pin?

I there a way to have a soft pin? Like libpysal can still be installed and used with numpy<=1.26, but we don't encourage it? I know some stuff I have going at work is tied to numpy<2 due to requirements outside my control, so I imagine others will be facing the same thing.

cc @sjsrey @knaaptime

We're either following SPEC 0 or we are not.

I there a way to have a soft pin? Like libpysal can still be installed and used with numpy<=1.26, but we don't encourage it?

As long as we don't make any change that would be incompatible, you can pip install with --no-deps even if pyproject says numpy>=2. But that still means testing against 1.26 and supporting it, so we can just do support that explicitly.

Given we adopted SPEC 0 specifically to avoid discussions like this, I find it a bit unfortunate that we have it.

This is not backwards compatible so we don't have to deal with that here.

I think tracking spec 0 is important. Trying to support outside of that window increases the maintenance cost.