TEST: add edge case tests for simport function (empty string, None)#1400
Open
AshishRaj97 wants to merge 1 commit into
Open
TEST: add edge case tests for simport function (empty string, None)#1400AshishRaj97 wants to merge 1 commit into
AshishRaj97 wants to merge 1 commit into
Conversation
Author
|
Hi! This is my first contribution to PySAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before submitting PR
You have run tests on this submission locally with
pytest.This submission is formatted and linted with
ruff.Docstrings and coverage are updated where applicable.
This pull request is directed to the
pysal/mainbranch.A reviewer has been assigned and relevant labels added.
Justification for this PR:
Added edge case tests for the
simportfunction:simport("")Noneinput:simport(None)These tests ensure that
simportsafely returns(False, None)for invalid module names without crashing, improving test coverage and robustness.