fixed issues with model handler failing to correctly discover models#802
Merged
Conversation
Member
Author
|
The notebook is screwed up. Let me patch it before merging, please! |
Member
Author
|
Ok, the notebook should be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The justification for this PR is:
The
handlercontrib module, which is a Patsy/Pandas wrapper for spreg, had a pretty severe regression of unknown origin. This causedregistry.pyto fail to discover all models inpysal.spreg, and resulted in complete loss of functionality for the handler.This was remedied by restricting the handler to only userclasses, changing the way arguments were parsed, and adding some name parsing to the patsy/pandas preparation step.
As a side effect, this PR also fixes the issue noted in the original specification, that additional unnamed positional arguments would pass silently through when the user supplied a formula. Now, this will not be the case.
In addition, tests were adapted to make sure the handler is now tested for all user classes in spreg. But, since this is in contrib, the handler won't get tested unless explicitly checked.