Skip to content

Fix xcfun scientific notation parse#1788

Merged
sunqm merged 2 commits into
pyscf:masterfrom
matthew-hennefarth:fix_dft_xc
Jul 13, 2023
Merged

Fix xcfun scientific notation parse#1788
sunqm merged 2 commits into
pyscf:masterfrom
matthew-hennefarth:fix_dft_xc

Conversation

@matthew-hennefarth

Copy link
Copy Markdown
Contributor

Fix issue #1787.

@matthew-hennefarth matthew-hennefarth changed the title Fixxcfun scientific notation parse Fix xcfun scientific notation parse Jul 6, 2023
@matthew-hennefarth

Copy link
Copy Markdown
Contributor Author

CI currently failing due to PR #1677.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1788 (3bc179a) into master (fc9995c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 3bc179a differs from pull request most recent head 7a1789a. Consider uploading reports for the commit 7a1789a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1788      +/-   ##
==========================================
- Coverage   85.50%   85.50%   -0.01%     
==========================================
  Files         792      792              
  Lines      160142   160144       +2     
  Branches    17575    17575              
==========================================
- Hits       136937   136936       -1     
- Misses      19568    19569       +1     
- Partials     3637     3639       +2     
Impacted Files Coverage Δ
pyscf/dft/test/test_xcfun.py 98.20% <100.00%> (+0.01%) ⬆️
pyscf/dft/xcfun.py 94.22% <100.00%> (ø)

... and 2 files with indirect coverage changes

@sunqm sunqm merged commit 469f593 into pyscf:master Jul 13, 2023
@matthew-hennefarth matthew-hennefarth deleted the fix_dft_xc branch August 8, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants