Add more tests for regression coverage #2142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure no future regressions occur
ofek
approved these changes
Dec 11, 2025
| project = Project(project_path) | ||
| helpers.update_project_environment(project, "default", {"dev-mode": False, **project.config.envs["default"]}) | ||
| helpers.update_project_environment( | ||
| project, "default", {"dev-mode": False, "extra-dependencies": ["binary"], **project.config.envs["default"]} |
Contributor
There was a problem hiding this comment.
What's the purpose of adding an extra dependency here to the base test for non-dev mode project installation? If this is not strictly required for testing correctness then I'd prefer to remove it.
Member
Author
There was a problem hiding this comment.
Without this it does not trigger that regression we saw because the regression was in the VirtualEnvironment.sync_dependencies functionality. This just ensures that code path always gets triggered.
github-actions bot
pushed a commit
to almir-hrvanovic/hatch
that referenced
this pull request
Dec 17, 2025
* Add more unit tests that cover regressions and additional cases to ensure no future regressions occur * Remove duplicated test * Fix formatting * Avoid isolation for new tests that pollutes in memory config tests 4776f11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for regression of dev-mode to ensure that it properly triggers the condition that caused the regression. It also adds additional tests to try to get more coverage on EnvironmentInterface for other potential areas that regressions in the future could occur.