-
Notifications
You must be signed in to change notification settings - Fork 3.2k
PEP-710: implement provenance_url.json file #11865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Checking the failed test: I'm not sure whether this PR introduces the given failure. Also, it looks like it fails only on Mac. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a very fast first review.
ba0d648 to
0ffeffd
Compare
550e00d to
7c1954b
Compare
|
We may want to add a test that verifies that provenance_url.json is created when installing a wheel found in cache. I think there is already such a test for download_info in the install report json. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @fridex!
2abed55 to
3ef0705
Compare
Added tests, PTAL. EDIT: docs CI failures do not seem to be related to this PR |
Signed-off-by: Fridolin Pokorny <fridolin.pokorny@gmail.com>
|
There is still a little something that is nagging me. This PR uses the However, the current PEP 710 draft does not reference that specification explicitly. So in theory there is a risk that if the Direct URL Data Structure specification evolves in the future, a change in |
Added links to the Direct URL data structure in python/peps#3887. Please let me know if you want to be more specific in some specific paragraph with the Direct URL data structure link. |
See PEP 710 - Recording the provenance of installed packages related PEP-710.