Skip to content

Twine have indirect Python 2 only dependency. #241

Description

@Carreau

Twine rely on clint which install args, which AFAICT has no published Python 3 compatible versions:

  File "/root/miniconda3/lib/python3.6/site-packages/args.py", line 394, in <module>
    flags = args.flags
  File "/root/miniconda3/lib/python3.6/site-packages/args.py", line 328, in flags
    return self.start_with('-')
  File "/root/miniconda3/lib/python3.6/site-packages/args.py", line 192, in start_with
    if _is_collection(x):
  File "/root/miniconda3/lib/python3.6/site-packages/args.py", line 37, in _is_collection
    if isinstance(obj, basestring):
NameError: name 'basestring' is not defined

Which has the side effect of breaking as soon as sphinx autolink kick in and try to figure out what blah blah `args` blah blah could mean as it import args. (numpy/numpy#9005)

It would be nice to have twine be completely Python 3 compatible.

The activity on Clint and Args make me doubt I'll get a response though, so opening issue here.

Activity

  1. di commented on Apr 27, 2017

    @di
    SponsorMember

    It seems like clint is only being used to generate a progress bar. Perhaps we could use tqdm (which is active and supports Python 3) instead?

  2. sigmavirus24 commented on Apr 27, 2017

    @sigmavirus24
    Member

    I'd merge a pull request that switches us over to tqdm. Thanks for pointing this out @Carreau. :)

  3. added 2 commits that reference this issue on Apr 27, 2017
    ab9656b
    4da3b23
  4. Carreau commented on Apr 27, 2017

    @Carreau
    ContributorAuthor

    I'd merge a pull request that switches us over to tqdm.

    See #242.

    Thanks for pointing this out @Carreau. :)

    Thanks to you for maintaining twine, and being responsive !

  5. added 4 commits that reference this issue on Apr 29, 2017
    f3b7492
    03bf142
    18ce611
    42e55e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions