Skip to content

Conversation

@MajorTanya
Copy link
Contributor

@MajorTanya MajorTanya commented May 2, 2025

Just a very small thing I noticed while reading the rendered docs at RTD. The space makes sure the inline code block is terminated after base_1 and therefore avoids rendering the entire sentence up to loc as a code section.

I wasn't sure which delineation was intended, so I kept the code as-is and just added the space. There is an alternative to include the =False in the code section as well:

- using ``with_line_numbers`` inside a parse action, set ``base_1``=False, since the
+ using ``with_line_numbers`` inside a parse action, set ``base_1=False``, since the

If the alternative is desired, I can quickly push that up instead. 👍

Edit: The odd formatting can currently be seen here.

Just a very small thing I noticed while reading the rendered docs at RTD. The space makes sure the inline code block is terminated after `base_1` and therefore avoids rendering the entire sentence up to `loc` as a code section.
@ptmcg ptmcg merged commit 15a106e into pyparsing:master May 7, 2025
@ptmcg
Copy link
Member

ptmcg commented May 7, 2025

Thanks - easy enough to merge as-is. Always nice to make the docs look better. I hope you are finding pyparsing helpful!

@MajorTanya MajorTanya deleted the patch-1 branch May 7, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants