Skip to content

Conversation

@heckad
Copy link
Contributor

@heckad heckad commented Jun 8, 2021

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #285 (9df4122) into master (d108a29) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   91.14%   91.30%   +0.15%     
==========================================
  Files          11       11              
  Lines        3253     3254       +1     
  Branches      713      713              
==========================================
+ Hits         2965     2971       +6     
+ Misses        176      173       -3     
+ Partials      112      110       -2     
Impacted Files Coverage Δ
pyparsing/helpers.py 95.03% <100.00%> (+0.01%) ⬆️
pyparsing/diagram/__init__.py 90.69% <0.00%> (+2.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d108a29...9df4122. Read the comment docs.

@ptmcg
Copy link
Member

ptmcg commented Jun 27, 2021

Note that the string used in setName(dlName) is not 100% accurate if allowTrailingDelim is True. Should probably update that also.

@heckad
Copy link
Contributor Author

heckad commented Jul 29, 2021

@ptmcg?

@ptmcg
Copy link
Member

ptmcg commented Jul 30, 2021

Sorry for being off-line for so long. Still learning my way around at the new job, and current project is pretty urgent.

I'll move your PR to the front of the line.

@ptmcg ptmcg merged commit 0e14999 into pyparsing:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants