[NEW] Feature Magnetic Stripe Reader #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf05e9a to
8618d4f
Compare
Contributor
|
Hi, thanks for the contribution ! I'm worried that Maybe this should be named more like magnetic_reader ? |
Contributor
|
After discussion at the OCA days, the magnetic stripe reader is like a scanner (not very different from a barcode scanner) to the computer. So the naming seems right because the plugin could be used for any kind of serial scanner. |
PierrickBrun
approved these changes
Oct 10, 2022
rvalyi
approved these changes
Oct 20, 2022
rvalyi
left a comment
There was a problem hiding this comment.
LGTM. May be pyserial==3.5 in the requirements.txt is a bit restrictive. Wouldn't pyserial>=3.5 just work?
Collaborator
|
@mileo could you rebase and fix conflict ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luis Felipe Mileo mileo@kmee.com.br
Implements integration with IDTech MSR, module of Odoo will be proposed to oca/pos in a few days.
https://idtechproducts.com/datasheets/SecureHead%20datasheet%20-%20A4_v02.22.pdf