Skip to content

fix: prevent tags from being passed to load_parameter_values function#1186

Merged
jetuk merged 2 commits into
masterfrom
param-tag-fix
Jun 8, 2026
Merged

fix: prevent tags from being passed to load_parameter_values function#1186
jetuk merged 2 commits into
masterfrom
param-tag-fix

Conversation

@Batch21

@Batch21 Batch21 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

This prevents the tags from being potentially passed to Pandas functions to read data from files resulting in an unexpected keyword error.

@Batch21

Batch21 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

This is a quick fix. Maybe the better approach would be to ensure that all parameter pass the tags args correctly on to the base component class?

@jetuk

jetuk commented Jun 2, 2026

Copy link
Copy Markdown
Member

Can you provide a regression test for this?

This prevents the tags from being potentially passed to Pandas functions to read data from files resulting in an unexpected keyword error.
@Batch21 Batch21 changed the title fix: prevent tags from being passed to parameter constructors fix: prevent tags from being passed to load_parameter_values function Jun 3, 2026
@jetuk jetuk merged commit 3521cf0 into master Jun 8, 2026
12 checks passed
@jetuk jetuk deleted the param-tag-fix branch June 8, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants