Add capability of benchmarking arbitrary binary#1107
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1107
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 87fdca9 with merge base cf573bd ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64247087 |
kimishpatel
added a commit
to kimishpatel/ao
that referenced
this pull request
Oct 17, 2024
Summary: Earlier version only allowed running binary that did not take any args and dependened on resources like model file, tokenizer file etc. This change adds capability of parsing args, sending args to aibench and parsing resources that also needs to be sent to aibench. TODO: add --local to the script to enable benchmarking on locally connected device. Reviewed By: swolchok Differential Revision: D64247087
3e3f45b to
67a8910
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64247087 |
kirklandsign
approved these changes
Oct 18, 2024
jerryzh168
approved these changes
Oct 23, 2024
67a8910 to
7416560
Compare
kimishpatel
added a commit
to kimishpatel/ao
that referenced
this pull request
Oct 24, 2024
Summary: Earlier version only allowed running binary that did not take any args and dependened on resources like model file, tokenizer file etc. This change adds capability of parsing args, sending args to aibench and parsing resources that also needs to be sent to aibench. TODO: add --local to the script to enable benchmarking on locally connected device. Reviewed By: swolchok, kirklandsign Differential Revision: D64247087
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64247087 |
Summary: Earlier version only allowed running binary that did not take any args and dependened on resources like model file, tokenizer file etc. This change adds capability of parsing args, sending args to aibench and parsing resources that also needs to be sent to aibench. TODO: add --local to the script to enable benchmarking on locally connected device. Reviewed By: swolchok, kirklandsign Differential Revision: D64247087
7416560 to
87fdca9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64247087 |
jainapurva
pushed a commit
that referenced
this pull request
Oct 24, 2024
Differential Revision: D64247087 Pull Request resolved: #1107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Earlier version only allowed running binary that did not take any args and
dependened on resources like model file, tokenizer file etc.
This change adds capability of parsing args, sending args to aibench and
parsing resources that also needs to be sent to aibench.
TODO: add --local to the script to enable benchmarking on locally connected
device.
Reviewed By: swolchok
Differential Revision: D64247087