Enable FSDP Test in CI#207
Merged
Merged
Conversation
weifengpy
approved these changes
May 2, 2024
Contributor
|
@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
i had the same issue of not finding hqq before. curious of the solution |
Contributor
Author
|
Taking a look |
Contributor
Author
|
Ok it worked just needed better import skips - waiting for @jerryzh168's ship it work to land before landing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeat of #206 but against main instead of my own branch 🤦