Skip to content

Enable {conv3d, conv_transpose3d} + bn fusion in pt2e#2212

Merged
jerryzh168 merged 3 commits into
pytorch:mainfrom
jerryzh168:convbn3d
May 15, 2025
Merged

Enable {conv3d, conv_transpose3d} + bn fusion in pt2e#2212
jerryzh168 merged 3 commits into
pytorch:mainfrom
jerryzh168:convbn3d

Conversation

@jerryzh168

Copy link
Copy Markdown
Contributor

Summary:
att, previously only 1d and 2d fusion are supported, this PR adds 3d support

Test Plan:
python test/quantization/pt2e/test_quantize_pt2e.py -k test_conv3d_bn_relu python test/quantization/pt2e/test_quantize_pt2e.py -k test_conv_transpose3d_bn_relu

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:
att, previously only 1d and 2d fusion are supported, this PR
adds 3d support

Test Plan:
python test/quantization/pt2e/test_quantize_pt2e.py -k test_conv3d_bn_relu
python test/quantization/pt2e/test_quantize_pt2e.py -k test_conv_transpose3d_bn_relu

Reviewers:

Subscribers:

Tasks:

Tags:
@pytorch-bot

pytorch-bot Bot commented May 15, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2212

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dc01886 with merge base 554cb60 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2025
@jerryzh168 jerryzh168 added topic: new feature Use this tag if this PR adds a new feature module: pt2e_quant pt2 export quantization (prepare_pt2e, convert_pt2e, quantizer) labels May 15, 2025
@jerryzh168 jerryzh168 added topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) and removed topic: new feature Use this tag if this PR adds a new feature labels May 15, 2025

@andrewor14 andrewor14 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PT2E feature in torchao but not in pytorch core? :)

@jerryzh168 jerryzh168 merged commit 5549da8 into pytorch:main May 15, 2025
21 checks passed
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
* Enable {conv3d, conv_transpose3d} + bn fusion in pt2e

Summary:
att, previously only 1d and 2d fusion are supported, this PR
adds 3d support

Test Plan:
python test/quantization/pt2e/test_quantize_pt2e.py -k test_conv3d_bn_relu
python test/quantization/pt2e/test_quantize_pt2e.py -k test_conv_transpose3d_bn_relu

Reviewers:

Subscribers:

Tasks:

Tags:

* comment

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: pt2e_quant pt2 export quantization (prepare_pt2e, convert_pt2e, quantizer) topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants