Patch the _is_conv_node function#2223
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2223
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New FailuresAs of commit 5d7f713 with merge base adc78b7 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74898941 |
pytorch-bot Bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 20, 2025
Summary: X-link: pytorch/ao#2223 torch.ops.aten.conv2d.padding is also conv2d node Test Plan: CI Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941
Contributor
Author
|
@jerryzh168 @andrewor14 can you help reviewing? |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74898941 |
cccclai
added a commit
to cccclai/ao
that referenced
this pull request
May 20, 2025
Summary: Pull Request resolved: pytorch#2223 X-link: pytorch/pytorch#153749 torch.ops.aten.conv2d.padding is also conv2d node Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941
jerryzh168
approved these changes
May 20, 2025
cccclai
added a commit
to cccclai/ao
that referenced
this pull request
May 22, 2025
Summary: X-link: pytorch/pytorch#153749 torch.ops.aten.conv2d.padding is also conv2d node Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74898941 |
Summary: X-link: pytorch/pytorch#153749 torch.ops.aten.conv2d.padding is also conv2d node Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74898941 |
cccclai
added a commit
to cccclai/pytorch
that referenced
this pull request
May 22, 2025
Summary: X-link: pytorch/ao#2223 torch.ops.aten.conv2d.padding is also conv2d node Test Plan: CI Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941
jerryzh168
reviewed
May 22, 2025
| self._test_quantizer( | ||
| TestHelperModules.ConvWithBNRelu(dim=2, relu=True, bn=True, padding="same"), | ||
| example_inputs, | ||
| BackendAQuantizer(), |
Contributor
There was a problem hiding this comment.
this is not annotating conv2d, does the test pass?
Closed
Contributor
|
@cccclai looks like this also breaks ruff, I'll revert first |
Contributor
|
oh thanks @HDCharles for the fix |
Contributor
|
we still need to revert this it caused a bunch of breakages. |
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Differential Revision: D74898941 Pull Request resolved: #2223
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/pytorch#153749
torch.ops.aten.conv2d.padding is also conv2d node
Reviewed By: andrewor14, jerryzh168
Differential Revision: D74898941