This repository was archived by the owner on Aug 7, 2025. It is now read-only.
feat: add KServe gRPC v2 support #2176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2176 +/- ##
==========================================
+ Coverage 72.85% 72.86% +0.01%
==========================================
Files 78 78
Lines 3695 3697 +2
Branches 58 58
==========================================
+ Hits 2692 2694 +2
Misses 999 999
Partials 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lxning
reviewed
Mar 15, 2023
| async_result = await grpc_stub.Predictions(payload) | ||
| return async_result | ||
|
|
||
| def postprocess( |
There was a problem hiding this comment.
I don't see this function is called. Could you add some comments (eg. which function call this one)?
| ) | ||
| return self.grpc_client_stub | ||
|
|
||
| async def _grpc_predict( |
There was a problem hiding this comment.
I don't see this function is called. Could you add some comments (eg. which function call this one)?
9 tasks
|
Somebody, please! Get this man approve 🙂 |
msaroufim
approved these changes
Jul 21, 2023
added 5 commits
August 4, 2023 12:17
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
- add logs Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
4647802 to
456d476
Compare
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
agunapal
suggested changes
Aug 7, 2023
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
26c25bf to
73a9f53
Compare
chauhang
approved these changes
Aug 24, 2023
agunapal
approved these changes
Aug 24, 2023
…serve-grpc Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add gRPC support for KServe v2 protocol
Depends on #2175
Fixes #1859
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B
Checklist: