Skip to content
This repository was archived by the owner on Aug 7, 2025. It is now read-only.

Find torchserve-plugins-sdk artifacts locally #2429

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Find torchserve-plugins-sdk artifacts locally #2429

merged 5 commits into from
Jun 23, 2023

Conversation

@namannandan
Copy link
Collaborator

@namannandan namannandan commented Jun 23, 2023 •
edited
Loading

Description

Sanity in CI currently fails with the following error:

A problem occurred evaluating project ':server'.
> Could not resolve all files for configuration ':server:runtimeClasspath'.
   > Could not find org.pytorch:torchserve-plugins-sdk:0.0.4.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/pytorch/torchserve-plugins-sdk/0.0.4/torchserve-plugins-sdk-0.0.4.pom
       - https://jcenter.bintray.com/org/pytorch/torchserve-plugins-sdk/0.0.4/torchserve-plugins-sdk-0.0.4.pom
     Required by:
         project :server

The torchserve-plugins-sdk are currently unavailable via JCenter or Maven Central repositories.

This PR implements a workaround to find torchserve-plugins-sdk artifacts locally using mavenLocal() until they are made available on maven central repository.

@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited
Loading

Codecov Report

Merging #2429 (0f50a85) into master (207477d) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 0f50a85 differs from pull request most recent head 2133d32. Consider uploading reports for the commit 2133d32 to get more accurate results

@@            Coverage Diff             @@
##           master    #2429      +/-   ##
==========================================
+ Coverage   71.92%   72.01%   +0.08%     
==========================================
  Files          78       78              
  Lines        3648     3648              
  Branches       58       58              
==========================================
+ Hits         2624     2627       +3     
+ Misses       1020     1017       -3     
  Partials        4        4

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@namannandan namannandan marked this pull request as ready for review June 23, 2023 20:54
@agunapal agunapal self-requested a review June 23, 2023 21:35
agunapal
agunapal reviewed Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall unless there is an easier workaround @lxning

@namannandan If we include building maven inside

python ts_scripts/install_dependencies.py --environment=dev

then , we can avoid having to update the workflow files

@namannandan namannandan force-pushed the naman_serving_sdk_workaround branch from 76215b4 to 2133d32 Compare June 23, 2023 22:37
@agunapal agunapal merged commit a77a150 into pytorch:master Jun 23, 2023
This was referenced Jun 26, 2023
Closed
Closed
@namannandan namannandan mentioned this pull request Jun 28, 2023
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@agunapal agunapal agunapal approved these changes

@lxning lxning lxning approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namannandan @agunapal @lxning