This repository was archived by the owner on Aug 7, 2025. It is now read-only.
Update add_metric API to be backwards compatible #2525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the custom metrics
add_metricAPI to be backwards compatible with Torchserve versions prior to v0.6.1.The
add_metricmethod retains the same API signature but the change in semantics is that v0.6.1 introduced types for metrics metricTypes and the default inferred type if not specified when usingadd_metricAPI isCOUNTER.add_metricAPI in versions prior to v0.6.1add_metricAPI in versions v0.6.1 onwardsadd_metricAPI introduced in this PR for backwards compatibility with versions prior to v0.6.1Type of change
Feature/Issue validation/testing