This repository was archived by the owner on Aug 7, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 889
Adding Performance Checklist to site #2526
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding performance checklist to site. Plan to add this checklist to FAQs page in the future as well. For now, it can be accessed through the performance page.
Codecov Report
@@ Coverage Diff @@
## master #2526 +/- ##
==========================================
+ Coverage 72.56% 72.64% +0.08%
==========================================
Files 79 79
Lines 3733 3733
Branches 58 58
==========================================
+ Hits 2709 2712 +3
+ Misses 1020 1017 -3
Partials 4 4 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
msaroufim
approved these changes
Aug 16, 2023
msaroufim
reviewed
Aug 16, 2023
msaroufim
reviewed
Aug 16, 2023
msaroufim
reviewed
Aug 16, 2023
msaroufim
suggested changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments inline
|
Made the updates |
msaroufim
approved these changes
Aug 16, 2023
chauhang
approved these changes
Aug 24, 2023
agunapal
approved these changes
Aug 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding performance checklist to site. Quick first run at the checklist.
Plan to add this checklist to FAQs page in the future as well. For now, it can be accessed through the performance page.
Fixes #(issue)
Adds to performance information
Please delete options that are not relevant.
Feature/Issue validation/testing
Built pages locally to ensure they work.
Checklist: