Apply various ruff fixes #170968
Closed
Apply various ruff fixes #170968
+84
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/170968
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 84465ab with merge base 3dc8009 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
f7e1883 to
76fd7c7
Compare
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
76fd7c7 to
84465ab
Compare
Contributor
|
Can we update the summary to list which fixes? I think it is fine for the title to be general but we should be sure to include details when we have the space (summary) |
Lucaskabela
approved these changes
Dec 22, 2025
Collaborator
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies various ruff experimental fixes to code. Most changes are about simplifying
ifconditions. These fixes were applied withruff --previewbut my view indicates that they are safe.cc @ezyang @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo @Lucaskabela