Replace deprecated numpy aliases #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhmerov
approved these changes
May 29, 2024
for more information, see https://pre-commit.ci
|
@akhmerov Tests are passing locally, not sure what is happening to the CI |
|
Thanks a lot! I think we first need to merge #404 to get the tests to pass. I'll do that in a few hours. |
|
Thanks all! 🙏 Would it make sense to do a new release with these changes? Or are there other steps still needed before releasing? |
|
@jakirkham I just released 1.3.0 🎉 |
|
Congratulations and thank you again! 🥳 🙏 |
Jose1654
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Numpy 2.0 is to be released soon (see numpy/numpy#24300 (comment)) and that release will remove a couple of deprecated aliases.
In this PR replace the aliases by the entries suggested by ruff (see https://docs.astral.sh/ruff/rules/numpy2-deprecation/)
Checklist
pre-commit run --all(first install usingpip install pre-commit)pytestpassedType of change
Check relevant option(s).