Skip to content

Trees missing in 1.3.0 #88

Closed
Closed

Description

@jaraco

In GitLab by @henryiii on Mar 6, 2020, 15:19

I just merged a PR that worked with 1.2.0 and in master it built with 1.3.0, and I get AttributeError: 'module' object has no attribute 'trees' (using exactly what is in the documentation).

https://importlib-resources.readthedocs.io/en/latest/migration.html#pkg-resources-resource-filename

Activity

  1. jaraco commented on Oct 21, 2020

    @jaraco
    MemberAuthor

    In GitLab by @henryiii on Mar 6, 2020, 15:23

    changed the description

  2. jaraco commented on Oct 21, 2020

    @jaraco
    MemberAuthor

    In GitLab by @henryiii on Mar 6, 2020, 15:30

    FYI, I've worked around it for now, but it's bad that the documentation refers to things now moved.

    scikit-hep/scikit-hep-testdata#27

  3. jaraco commented on Oct 21, 2020

    @jaraco
    MemberAuthor

    In GitLab by @jaraco on Mar 6, 2020, 16:28

    That's a mistake. I created a trees module to maintain compatibility but probably forgot to add it.

  4. jaraco commented on Oct 21, 2020

    @jaraco
    MemberAuthor

    In GitLab by @jaraco on Mar 6, 2020, 16:28

    I'll have a fix shortly.

  5. jaraco commented on Oct 21, 2020

    @jaraco
    MemberAuthor

    In GitLab by @jaraco on Mar 6, 2020, 16:34

    I thought I'd updated the docs to reflect the preferred usage. I guess I missed that in a couple of places too.

  6. jaraco commented on Oct 21, 2020

    @jaraco
    MemberAuthor

    In GitLab by @jaraco on Mar 6, 2020, 16:35

    closed via commit 3b5d345

  7. jaraco commented on Oct 21, 2020

    @jaraco
    MemberAuthor

    In GitLab by @jaraco on Mar 6, 2020, 16:35

    This should be fixed in 1.3.1, rolling out now.

  8. jaraco commented on Oct 21, 2020

    @jaraco
    MemberAuthor

    In GitLab by @jaraco on Mar 19, 2020, 23:10

    mentioned in commit 3b5d345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions