feat: base sepolia support#5697
Merged
Merged
Conversation
Collaborator
|
Thanks for the PR! Will review after work today. |
Contributor
Author
|
I'm testing running this but unluckily it doesn't advance blocks Here is our op-node logs op-reth logs |
clabby
suggested changes
Dec 5, 2023
Contributor
Author
|
Still got the error which is nonsense as it error about BlockGasUsed op-geth op-node |
Collaborator
|
Gotcha! I can take a look this weekend. In the meantime, is your L1 Sepolia node an archive node? |
Contributor
Author
|
It's a quicknode one (50$/month plan) which should be an archive node |
|
Any update here? 🙂 |
Contributor
Sync version
Contributor
Author
|
https://base-sepolia.blockscout.com/block/1 Block hash: 0x44b31f42f3327b2497c94acd1d62dd3965b23da06268316e6085dbaf9900c22c But in reth it says 0x44b52cadd963750a046be3fa0e4f520fa2d4d22b5222e1a8034295c9d2fc6b6c which is invalid |
Collaborator
|
the gas mismatch is very odd, not sure where the (gas_used: 1000000) gas_used is coming from? but this is wrong? if I query the first base sepolia block: I get gas used by the block: and for the systemTx: @Chomtana if I read the logs correctly then it looks like the op-node sends an invalid payload to op-reth? hmm, this entire setup is very confusing to me, why is there payload building involved here? |
Collaborator
|
Update: I think I've found the bug; regolith is timestamp based hardfork and must be initialized as such, see also BASE_MAINNET: https://github.com/paradigmxyz/reth/blob/main/crates/primitives/src/chain/spec.rs#L421-L421 this would explain the wrong gas_used because there are no refunds if regolith is not activated. mind giving this another try @Chomtana ? |
Contributor
Author
|
Testing now. Thank you very much |
Contributor
Author
|
@mattsse it's looking good rethop-node |
mattsse
approved these changes
Dec 27, 2023
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
great!
in that case, happy to include this, all chainspec values look fine to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added base sepolia support to reth which should fixes #5653
However, I have not added test cases yet as I don't know how to get base_sepolia_forkids. It would be great if team can advise me on this.
If this looks good will proceed with op sepolia support.