You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split out of #481/#483 (small-model context-management work).
`McpChatConfig.context_length` and `LlmClient::with_num_ctx` exist and work correctly where they're wired (e.g. `ahma_tui`'s `resolve_token_prefs` → the daemon-hub `SubmitPrompt` path in `ahma_core::agent`'s hub prompt runner). But several other `LlmClient::new(...)` call sites never call `.with_num_ctx(...)`, and `ahma_core::agent::build_agent_run_context` hardcodes `context_length: None` even though `resolve_llm_connection` already resolves the real `num_ctx` right there.
Why this matters
Two features now depend on `context_length` being populated to do anything useful:
Add a regression test asserting `context_length` is non-`None` whenever `num_ctx` is configured for a provider, for at least the primary TUI chat path.
Background
Split out of #481/#483 (small-model context-management work).
`McpChatConfig.context_length` and `LlmClient::with_num_ctx` exist and work correctly where they're wired (e.g. `ahma_tui`'s `resolve_token_prefs` → the daemon-hub `SubmitPrompt` path in `ahma_core::agent`'s hub prompt runner). But several other `LlmClient::new(...)` call sites never call `.with_num_ctx(...)`, and `ahma_core::agent::build_agent_run_context` hardcodes `context_length: None` even though `resolve_llm_connection` already resolves the real `num_ctx` right there.
Why this matters
Two features now depend on `context_length` being populated to do anything useful:
Both are currently inert on any code path that doesn't already thread `context_length` through by hand.
Scope