[docs] Record + dismiss tough<0.22 Dependabot advisories (no upstream fix)#266
Merged
Conversation
The two high-severity Dependabot alerts are both `tough` < 0.22.0 (TUF delegated-metadata validation + signature-threshold bypass), pulled in transitively via sigstore-verification 0.2.8 -> sigstore 0.13.0. There is no clean version-bump fix: tough 0.22 only arrives via sigstore 0.14, and no published sigstore-verification depends on sigstore ^0.14 (0.2.8, latest, still pins ^0.13 -> tough ^0.21). The vulnerable code is reachable only through the opt-in self-update attestation path (`ahma update` / `ahma verify`), never the MCP server or sandbox runtime. - Add docs/security-advisories.md: a register of accepted/tracked third-party advisories, with the full dependency analysis, why the residual risk is tolerable, and the exact closing condition (bump once sigstore-verification adopts sigstore ^0.14). - Cross-reference it from docs/release-signing.md. - Dismiss alerts #9 and #10 as tolerable_risk, pointing at the doc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> EOF 2>&1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the 2 high-severity Dependabot alerts flagged on
main. Both are the same crate —tough< 0.22.0:Why there's no version-bump fix
Dependency path:
ahma_mcp → sigstore-verification 0.2.8 → sigstore 0.13.0 → tough 0.21.0.tough 0.22(the fix) only arrives viasigstore 0.14(tough ^0.22). Reaching it needssigstore-verificationto depend onsigstore ^0.14, but no published version does —0.2.8(latest) still pinssigstore ^0.13→tough ^0.21. Acargo update/--precisebump is rejected by the resolver, and[patch.crates-io]can't satisfy^0.21with0.22.x. Forcing it would mean vendoring/forkingsigstore-verificationontosigstore 0.14(0.13→0.14 API adaptation + maintained third-party code).Why the residual risk is tolerable
toughis reachable only through the opt-in self-update attestation path —ahma update/ahma verify→update::verify::verify_artifact→sigstore_verification::verify_github_attestation. It is not in the MCP server, the sandbox, or any normal runtime path. Exploiting it requires subverting the Sigstore public-good TUF CDN at the moment a user runs an attested update. Release artifacts are also checksum-verified independently.What this PR does
docs/security-advisories.md— a register of accepted/tracked advisories with the full analysis, tolerable-risk rationale, and the exact closing condition (bump oncesigstore-verificationadoptssigstore ^0.14).docs/release-signing.md.tolerable_riskvia the API, each pointing at the doc. 0 open alerts remain.No code or dependency changes — this is a documented, tracked acceptance, to be closed automatically when upstream ships
sigstore-verificationonsigstore 0.14.🤖 Generated with Claude Code