FISH-8904 - add pipeline PR and build the 4 projects #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jGauravGupta
approved these changes
Aug 13, 2024
27d0187 to
d43e2a3
Compare
Contributor
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the tests appeared to be related to maven-plugin-plugin. When the version is <3.11.0, the tests pass with the current code. But with v3.11.0 and above (currently 3.13.1), it requires MavenProject and MavenSession to be declared as @parameter, not @component.
Also, payara.version needs to be the same in the payara-micro-maven-plugin pom and in the 2 pom used in the tests, or the version of payara-micro in the test pom won't be found to run the test.