models: port to hishel 1.0 #3700
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ae5d0e to
a3d89d9
Compare
fd84e98 to
4bea968
Compare
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
4bea968 to
56b87fe
Compare
frostming
reviewed
Dec 15, 2025
Collaborator
frostming
left a comment
There was a problem hiding this comment.
This change is generally good, with some minor tweaks
| storage = hishel.FileStorage(serializer=MsgPackSerializer(), base_path=cache_dir, ttl=CACHES_TTL) | ||
| controller = hishel.Controller() | ||
| # clean up old (pre-hishel 1.0) cache | ||
| cache_db = cache_dir / "pdm.db" |
Collaborator
There was a problem hiding this comment.
I'd like the file to be named http-cache.sqlite
| if self.connection is None: | ||
| # Create cache directory and resolve full path on first connection | ||
| parent = self.database_path.parent if self.database_path.parent != Path(".") else None | ||
| full_path = hishel._utils.ensure_cache_dict(parent) / self.database_path.name |
Collaborator
There was a problem hiding this comment.
It's not worth a import from hishel._utils, just use path.mkdir() instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
SyncSqliteStorageFixes: #3657