Summary of Changes

Hello @peacock0803sz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience by providing immediate and dynamic context about the agent's execution environment directly within the chat interface. By streaming detailed environment information from the backend and displaying it in a dedicated status line, users can quickly understand which host, repository, branch, and model an agent is operating with. This change improves transparency and debugging capabilities during agent interactions.

Highlights

• Agent Environment Information Streaming: Introduced a new EnvironmentInfo message within the StreamEvent protobuf, which is now emitted as the very first event (sequence=1) for each agent execution. This event provides crucial context about the execution environment, including the hostname, Git repository details (owner/repo, branch), agent type, and the specific model name being used.
• Git Information Extraction: Added new backend utilities to dynamically retrieve Git repository and branch information from the current working directory. This information is then included in the EnvironmentInfo stream event.
• Dynamic Status Line UI: Implemented a new frontend StatusLine component and a useStatusLine hook to parse and display the streamed EnvironmentInfo in the chat interface. This provides users with real-time context about the agent's operating environment.
• Agent Adapter Model Naming: Extended the AgentAdapter interface with a ModelName() method, allowing each agent adapter (e.g., Claude) to report its specific model identifier, which is then surfaced in the EnvironmentInfo.
• Frontend Test Infrastructure: Integrated Vitest for frontend testing, including configuration and a setup file, to enable robust unit and component testing for React components and hooks.
• Prompt Input Usability Improvement: Modified the prompt input component to change the message submission hotkey from Enter (without Shift) to Ctrl+Enter or Meta+Enter, and updated the placeholder text to reflect this change.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

@claude Can you review this PR?

@claude once again, cloud you review this?

Claude finished @peacock0803sz's task in 1m 50s —— View job

PR Review: ✨ Add status line showing execution environment info

• Read PR context and changed files
• Review proto changes
• Review backend changes (gitinfo.go, agent_server.go, adapters)
• Review frontend changes (StatusLine, useStatusLine, routes)
• Review tests
• Post final review

Overall this is a well-scoped feature with good test coverage. There are a few issues worth addressing before merge, ranging from a guideline violation to a functional bug.

Critical: Japanese comments violate project guidelines

CLAUDE.md requires "All documentation must be in English", but there are Japanese comments scattered throughout the new code:

This affects readability for international contributors. Gemini Code Assist has already suggested specific English translations for each of these. Fix this →

Bug: GetGitInfo() uses the server's working directory, not the project directory

back/internal/server/gitinfo.go:16 and back/internal/server/agent_server.go:89

// GetGitInfo runs git commands from os.Getwd() — the server's process CWD
gitInfo := GetGitInfo()

But the project the agent is working in is msg.WorkingDirectory. This means:

• The status line will always show the server's own git repo context (i.e., the vibra repository itself), not the user's project.
• All concurrent sessions will show identical repository/branch info regardless of their actual working directories.

The fix is to accept a directory parameter:

func GetGitInfo(dir string) GitInfo { ... }
// and pass it down to GetBranch / getRemoteURL via exec.Command("-C", dir, ...)

Then call it as GetGitInfo(msg.WorkingDirectory). Fix this →

Bug: Stale status line between sessions

front/app/lib/hooks/useStatusLine.ts:55

prevRef.current = next;
return next;

When a new execution starts, useAgent likely clears events (sets it to []). In that state, findLatestEnvironment returns undefined and the hook returns prevRef.current — which still holds data from the previous session. The user will see the previous session's repo/branch/model until the new EnvironmentInfo arrives. Consider resetting prevRef when events.length === 0:

if (!latestEvent || latestEvent.payload.case !== "environment") {
  if (events.length === 0) {
    prevRef.current = { hostname: FALLBACK, repository: FALLBACK, branch: FALLBACK, agentType: FALLBACK, modelName: FALLBACK };
  }
  return prevRef.current;
}

Concern: Ref mutation during render

front/app/lib/hooks/useStatusLine.ts:55

prevRef.current = next;  // mutating a ref during render
return next;

React's concurrent mode can invoke the render function multiple times. Mutating a ref during render is unsafe and can produce inconsistent state. The canonical pattern is to return the computed value and let callers use useMemo/useEffect if needed, or to store the previous value in state rather than a ref.

Minor: Unnecessary array copy in findLatestEnvironment

front/app/lib/hooks/useStatusLine.ts:22

return [...events].reverse().find((e) => e.payload.case === "environment");

This copies and reverses the entire array on every render. As the event stream grows this becomes wasteful. A simple reverse-iteration loop avoids the allocation:

for (let i = events.length - 1; i >= 0; i--) {
  if (events[i].payload.case === "environment") return events[i];
}
return undefined;

Minor: Test robustness issues in gitinfo_test.go

Line 81: string(out[:len(out)-1]) strips exactly one byte. On CRLF systems, this leaves \r attached to the hash. Use strings.TrimSpace(string(out)) instead (consistent with how GetBranch itself does it).

Lines 119, 64-68: git init -b main requires git ≥ 2.28 and errors are silently ignored via _ = cmd.Run(). As copilot noted, this makes the test silently pass on older git versions without actually setting up the repo. Consider checking errors in the run helper.

Nit: Internal requirement IDs in comments

back/internal/server/agent_server.go:87

// Emit EnvironmentInfo as sequence=1 before container start (FR-001, FR-007)

FR-001/FR-007 are internal requirement IDs not visible in the repo. A brief functional description would be more useful for future contributors.

Positive notes

• Proto design is clean — good field-level comments on EnvironmentInfo explaining fallback semantics
• The sequence=1 reservation pattern is well-implemented and tested
• StatusLine component is nicely self-contained with appropriate truncation for long repo/branch names
• FR-011 value preservation is a thoughtful UX detail and well tested
• Vitest integration is set up cleanly
  | Branch

@claude fixed, re-review them!

Claude finished @peacock0803sz's task in 1m 49s —— View job

Re-review: All major issues resolved ✅

All previously raised issues have been addressed across three commits (d158d4c, b76e7be, 0e78fad). Here's the status of each item:

✅ Japanese comments (Critical → Fixed)

All files now have English-only comments and test descriptions. Translation is accurate and natural in every location I checked. No remaining Japanese text found.

✅ GetGitInfo() directory bug (Bug → Fixed)

back/internal/server/gitinfo.go:16 now accepts a dir string parameter and passes it via git -C <dir> to both GetBranch and getRemoteURL. The call site at agent_server.go:89 correctly passes msg.WorkingDirectory. Concurrent sessions will now see their own repo/branch context.

✅ Stale status line + ref mutation (Bug + Concern → Fixed)

front/app/lib/hooks/useStatusLine.ts has been completely rewritten with useMemo — no ref, no mutation during render. The new approach is notably cleaner:

export function useStatusLine(events: StreamEvent[]): StatusLineData {
  return useMemo(() => {
    let result = DEFAULT_DATA;
    for (const event of events) {
      if (event.payload.case === "environment") {
        const env = event.payload.value;
        result = {
          hostname: env.hostname || result.hostname,
          // ...
        };
      }
    }
    return result;
  }, [events]);
}

This elegantly handles two scenarios:

• FR-011 (preserve across events): because the events array is cumulative, old non-empty values from earlier events naturally win over later empty fields during the forward pass.
• Session reset: when events resets to [] for a new session, the loop produces no results and DEFAULT_DATA ("-" for all) is returned immediately — no stale data.

✅ Unnecessary array copy (Minor → Fixed)

The [...events].reverse().find(...) pattern is gone. The forward accumulation loop is O(n) and allocation-free, which is better than the originally suggested reverse loop.

✅ gitinfo_test.go robustness (Minor → Fixed)

Both issues corrected:

• commitHash now uses strings.TrimSpace(string(out)) instead of string(out[:len(out)-1]) — safe on CRLF too.
• TestGetBranch_NormalBranch now uses a run helper that calls t.Fatalf on error, uses git init + git checkout -b main (compatible with older git), and adds the required user.email/user.name config so --allow-empty commits work without global git config.

⚠️ Nit still remaining: internal requirement IDs in comment

back/internal/server/agent_server.go:87:

// Emit EnvironmentInfo as sequence=1 before container start (FR-001, FR-007)

FR-001/FR-007 are internal requirement IDs not present in the repository. Not a blocker — just worth replacing with a brief functional description for future contributors who won't have access to the requirements doc.

Summary

Every critical and substantive issue from the first review has been cleanly resolved. The useStatusLine rewrite in particular is a significant improvement — simpler, correct under React concurrent mode, and handling both FR-011 and session resets naturally. The only outstanding item is the internal requirement ID nit on line 87 of agent_server.go, which is non-blocking.

This PR is ready to merge pending the minor nit above (or merge as-is, the nit is truly cosmetic).
| Branch