Skip to content

command/expand: fix data race for concurrent writes #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sonmezonur merged 3 commits into from
Aug 2, 2021
Merged

command/expand: fix data race for concurrent writes #330

sonmezonur merged 3 commits into from
Aug 2, 2021

Conversation

@sonmezonur
Copy link
Member

@sonmezonur sonmezonur commented Jul 29, 2021

  • Concurrent write to objFound bool is not thread-safe. Use atomic boolean to avoid data race.

When I run TestExpandSources with the race detector, it shows data race warnings.

go test -race -mod=vendor -count=1 -run="TestExpandSources" ./...

WARNING: DATA RACE
Write at 0x00c0000b673c by goroutine 30:
  github.com/peak/s5cmd/command.expandSources.func1.1()
      .../go/src/github.com/peak/s5cmd/command/expand.go:79 +0x1d5

Previous write at 0x00c0000b673c by goroutine 29:
  github.com/peak/s5cmd/command.expandSources.func1.1()
      .../go/src/github.com/peak/s5cmd/command/expand.go:79 +0x1d5

Goroutine 30 (running) created at:
  github.com/peak/s5cmd/command.expandSources.func1()
      .../go/src/github.com/peak/s5cmd/command/expand.go:65 +0x1e5

Goroutine 29 (finished) created at:
  github.com/peak/s5cmd/command.expandSources.func1()
      .../go/src/github.com/peak/s5cmd/command/expand.go:65 +0x1e5

@sonmezonur
command/expand: fix data race for concurrent writes
b473e93 
* Concurrent write to objFound bool is not thread-safe. Use atomic boolean
  to avoid data race.
@sonmezonur
atomic/bool: update reference name
ccf718b
@sonmezonur sonmezonur requested a review from a team as a code owner July 29, 2021 10:15
@sonmezonur sonmezonur requested review from aykutfarsak and igungor and removed request for a team July 29, 2021 10:15
@sonmezonur sonmezonur merged commit d80fc02 into master Aug 2, 2021
@sonmezonur sonmezonur deleted the atomic_bool branch August 2, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igungor igungor igungor approved these changes

+1 more reviewer

@aykutfarsak aykutfarsak aykutfarsak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sonmezonur @igungor @aykutfarsak