Skip to content

storage: do not retry on expired token #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igungor merged 2 commits into from
Aug 11, 2021
Merged

storage: do not retry on expired token #337

igungor merged 2 commits into from
Aug 11, 2021

Conversation

@ocakhasan
Copy link
Contributor

@ocakhasan ocakhasan commented Aug 6, 2021

  • Do not retry on ExpiredToken, ExpiredTokenException and InvalidToken.

resolves #244

@ocakhasan ocakhasan requested a review from a team as a code owner August 6, 2021 09:34
@ocakhasan ocakhasan requested review from igungor and seruman and removed request for a team August 6, 2021 09:34
@ocakhasan ocakhasan changed the title all: do not retry on expired token storage: do not retry on expired token Aug 6, 2021
@igungor igungor merged commit 5ba7ee0 into peak:master Aug 11, 2021
@ocakhasan ocakhasan deleted the token branch August 11, 2021 15:20
@MqllR MqllR mentioned this pull request Nov 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igungor igungor igungor approved these changes

@seruman seruman seruman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

s5cmd slow startup

3 participants

@ocakhasan @igungor @seruman