normalizeParentIds: cannot read property toLowerCase of null when source is not set #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n source is not set
missinglink
approved these changes
Feb 21, 2021
Member
missinglink
left a comment
There was a problem hiding this comment.
👍 happy to merge this, are we waiting on feedback from #1515 or are we good to go?
Member
Author
|
Good to go, I tried with old schema and new schema with pelias-model 9.0.0 The PR is linked with the issue |
Member
|
Nice, thanks for fixing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing pelias/schema#475 and I found a bug (introduced by me 😞) when we use the new pelias-schema.
When
${placeType}_sourceis not set explicitly, the model will return[ null ].This is annoying because when we use
_.get(place, `${placeType}_source`, ['whosonfirst'])it will return[ null ]because the array is not undefined...And when we use
_.get(place, `${placeType}_source[0]`, 'whosonfirst')it will returnnulland not the default value becausenullis not undefined (see lodash doc) 😞.I fixed all tests for pelias-model 9.0.0 and added a new one
fixes #1515