Handle sources and layers param with address filter #1693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just helps separate the "when" from the "how"
As reported in #1653, there is an issue when negative sources are specified in combination with negative layers. The end result is that the negative layers are ignored. This issue was likely introduced in #1604 or #1525, the pull requests where we added the concept of negative sources and layers and subsequently improved them. Fixes #1525
missinglink
approved these changes
Mar 31, 2025
| t.deepEqual(clean.layers.sort(), expected_layers, 'layer list is reduced to exclude addresses'); | ||
| t.end(); | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
I'm struggling to understand a few things about this unit test:
- The test is named "exclude addresses when negative layers and sources are specified", is this specific to the
addresslayer? clean_layersfilters outvenueand sorts the array, thenexpected_layersdoes the same thing? Is this maybe to avoid sharing the same pointer asclean_layers?- The selected
sourcesare not being asserted.
Member
Author
There was a problem hiding this comment.
That's right, the entire _address_layer_filter file is centered around an optimization to filter out the address layer when two conditions are met:
- the input has certain parses, is below a certain number of tokens, etc
- the layers specified by the user are compatible with filtering out addresses. For example
layers=addressesmeans we can't, butlayers=-venuemeans we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1653, there is an issue when negative sources are specified in combination with negative layers. The end result is that the negative layers are ignored.
This issue was likely introduced in #1604 or #1525, the pull requests where we added the concept of negative sources and layers and subsequently improved them.
The change is split into two commits, a pure refactoring for clarity, and then the fix, which is quite short.
Fixes #1653