Skip to content

Conversation

@cgohlke
Copy link
Member

@cgohlke cgohlke commented Apr 3, 2025

Description

This PR bumps the Cython dependency to version 3.1.0b1 (released today), which fixes some long standing bugs relevant to this project:

Workarounds for Cython<3.1 are removed. Masking operations should now be more efficient and the phasor_threshold output data type matches the input type. The output of the graphical_component_analysis is explicitly set to uint64.

This PR also adds a flag to signal free-threading compatibility (tested on my Windows system).

Checklist

  • The pull request title and description are concise.
  • Related issues are linked in the description.
  • New dependencies are explained.
  • The source code and documentation can be distributed under the MIT license.
  • The source code adheres to code standards.
  • New classes, functions, and features are thoroughly tested.
  • New, user-facing classes, functions, and features are documented.
  • New features are covered in tutorials.
  • No files other than source code, documentation, and project settings are added to the repository.

@cgohlke cgohlke added the enhancement New feature or request label Apr 3, 2025
@cgohlke cgohlke requested a review from Copilot April 3, 2025 22:11
@cgohlke cgohlke self-assigned this Apr 3, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • requirements_dev.txt: Language not supported
  • src/phasorpy/_phasorpy.pyx: Language not supported

@cgohlke cgohlke requested a review from bruno-pannunzio April 3, 2025 22:12
Copy link
Contributor

@bruno-pannunzio bruno-pannunzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great news @cgohlke, good to have these already supported.

@cgohlke cgohlke merged commit 8d9e355 into phasorpy:main Apr 9, 2025
15 checks passed
@cgohlke cgohlke deleted the cython31 branch April 9, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants