-
Notifications
You must be signed in to change notification settings - Fork 13
Improve PhasorPlot class and its cursor methods #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @bruno-pannunzio : can you check these changes work for you when you have the time? |
|
Hi @cgohlke, this looks very promising, I like the idea of adding this options. I don't think I will be able to review it today, but tomorrow or the next day for sure. |
bruno-pannunzio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cgohlke! Thank you very much for all these changes. I’ve gone through them and they’re excellent improvements. They not only make the tutorials much clearer but also simplify common analyses, with the cursor updates being especially helpful.
One minor comment, I think in the PR title and description you meant improvements to the PhasorPlot class intead of PhasorPy. But other than that I think everything else is OK.
|
Thanks @bruno-pannunzio |
Description
This PR contains several bug fixes and improvements, mostly related to the PhasorPy class and its cursor methods:
PhasorPlot.__init__.PhasorPlotmethods, includingcursorandsemicircle.PhasorPlot.legendmethod.PhasorPlot.cursorandpolar_cursormethods:cursormethod to draw Cartesian style cursors by default.lsandlwparameters instead oflinestyleorlinewidth.align_semicircleparameter from cursor methods and also mask functions. Instead, add option to pass'phase'or'semicircle'literals toangleparameters.Checklist