Skip to content

Conversation

@cgohlke
Copy link
Member

@cgohlke cgohlke commented Aug 19, 2025

Description

This PR contains several bug fixes and improvements, mostly related to the PhasorPy class and its cursor methods:

  • Fix handling limits and ticks in PhasorPlot.__init__.
  • Add option to pass labels to many PhasorPlot methods, including cursor and semicircle.
  • Add PhasorPlot.legend method.
  • Improve PhasorPlot.cursor and polar_cursor methods:
    • Support drawing multiple cursors of same style.
    • Draw in major grid style.
    • Add option to control drawing circles or crosshair limited by circle.
    • Add option to control drawing polar or Cartesian style cursors.
    • Change cursor method to draw Cartesian style cursors by default.
    • Allow ls and lw parameters instead of linestyle or linewidth.
    • Remove align_semicircle parameter from cursor methods and also mask functions. Instead, add option to pass 'phase' or 'semicircle' literals to angle parameters.
  • Update tests, docstrings, and tutorials accordingly.
  • More consistently use lists for array-like parameters.
  • Add favicon.

Checklist

  • The pull request title and description are concise.
  • Related issues are linked in the description.
  • New dependencies are explained.
  • The source code and documentation can be distributed under the MIT license.
  • The source code adheres to code standards.
  • New classes, functions, and features are thoroughly tested.
  • New, user-facing classes, functions, and features are documented.
  • New features are covered in tutorials.
  • No files other than source code, documentation, and project settings are added to the repository.

@cgohlke cgohlke requested a review from Copilot August 19, 2025 01:18
@cgohlke cgohlke self-assigned this Aug 19, 2025
@cgohlke cgohlke added the enhancement New feature or request label Aug 19, 2025

This comment was marked as outdated.

@cgohlke
Copy link
Member Author

cgohlke commented Aug 19, 2025

Hi @bruno-pannunzio : can you check these changes work for you when you have the time?

@bruno-pannunzio
Copy link
Contributor

Hi @cgohlke, this looks very promising, I like the idea of adding this options. I don't think I will be able to review it today, but tomorrow or the next day for sure.

@cgohlke cgohlke mentioned this pull request Aug 20, 2025
26 tasks
Copy link
Contributor

@bruno-pannunzio bruno-pannunzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cgohlke! Thank you very much for all these changes. I’ve gone through them and they’re excellent improvements. They not only make the tutorials much clearer but also simplify common analyses, with the cursor updates being especially helpful.

One minor comment, I think in the PR title and description you meant improvements to the PhasorPlot class intead of PhasorPy. But other than that I think everything else is OK.

@cgohlke cgohlke changed the title Improve PhasorPy class and its cursor methods Improve PhasorPlot class and its cursor methods Aug 20, 2025
@cgohlke cgohlke merged commit 458d59a into phasorpy:main Aug 20, 2025
14 checks passed
@cgohlke cgohlke deleted the phasorplot branch August 20, 2025 16:27
@cgohlke
Copy link
Member Author

cgohlke commented Aug 20, 2025

Thanks @bruno-pannunzio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants