Skip to content

Bad convertion CalculationPercent to SpecifiedTradeAllowanceCharge #17

Description

@L3Mars

Hello Philip,

I'm using your CIIToUBL converter and it looks like there is a problem converting the CalculationPercent to MultiplierFactorNumeric.

    if (aAllowanceCharge.getCalculationPercent () != null)
    {
      // TODO calc is correct?
      aUBLAllowanceCharge.setMultiplierFactorNumeric (aAllowanceCharge.getCalculationPercentValue ().divide (CGlobal.BIGDEC_100));
    }

I think CalculationPercent should not be divided by 100

You can see the documentation of MultiplierFactorNumeric here

MultiplierFactorNumeric
Line level allowance or charge percentage
The percentage that may be used, in conjunction with the line level allowance base amount, to calculate the line level allowance or charge amount.
Example value: 20

PS: Thank you very much for all your work :)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions