Skip to content

Prioritize explicit PI ref over PHOTON_INHERIT #164

Closed

Description

@noble-ux

Ideal Behaviour

Vehicles with the following code should pull a predefined PI config if available:
HasPhoton = true, Photon = "PHOTON_INHERIT"

Actual Behaviour

Currently this script will prevent a photon config from using a predefined PI config. Currently this code actually needs to be removed in order to utilize the PI config without referencing it directly as seen below:
HasPhoton = true, Photon = "sgm_fpiu20"

Activity

  1. added
    bugSomething's broken that shouldn't be.
    on Aug 27, 2020
  2. JoshPiper commented on Aug 28, 2020

    @JoshPiper
    Member

    Not a bug? Intended behaviour is to leave blank with those.
    Registered PI isn't indexed by model, so that can't be used automatically pulled.

  3. added
    enhancementAn improvement to an already existing feature
    and removed
    bugSomething's broken that shouldn't be.
    on Aug 28, 2020
  4. noble-ux commented on Aug 28, 2020

    @noble-ux
    MemberAuthor

    We can move it around so
    explicit PI ref (table or name) > default > inherit

    Partial documentation issue, but ideally PI lighting would always be set to on when a model with a referenced PI is being used.

  5. changed the title [-]PHOTON_INHERIT pulls an empty config[/-] [+]Prioritize explicit PI ref over PHOTON_INHERIT[/+] on Aug 28, 2020
  6. added a commit that references this issue on Aug 18, 2026
    4c9ac79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementAn improvement to an already existing feature

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions